Skip to content

Add the Event Trigger - #115

Merged
poad merged 3 commits into
mainfrom
feat/opencode-pull-request
Sep 20, 2025
Merged

Add the Event Trigger#115
poad merged 3 commits into
mainfrom
feat/opencode-pull-request

Conversation

@poad

@poad poad commented Sep 20, 2025

Copy link
Copy Markdown
Owner

No description provided.

@amazon-q-developer

Copy link
Copy Markdown
Contributor

Code review in progress. Analyzing for code quality issues and best practices. Detailed findings will be posted upon completion.

Using Amazon Q Developer for GitHub

Amazon Q Developer1 is an AI-powered assistant that integrates directly into your GitHub workflow, enhancing your development process with intelligent features for code development, review, and transformation.

Slash Commands

Command Description
/q <message> Chat with the agent to ask questions or request revisions
/q review Requests an Amazon Q powered code review
/q help Displays usage information

Features

Agentic Chat
Enables interactive conversation with Amazon Q to ask questions about the pull request or request specific revisions. Use /q <message> in comment threads or the review body to engage with the agent directly.

Code Review
Analyzes pull requests for code quality, potential issues, and security concerns. Provides feedback and suggested fixes. Automatically triggered on new or reopened PRs (can be disabled for AWS registered installations), or manually with /q review slash command in a comment.

Customization

You can create project-specific rules for Amazon Q Developer to follow:

  1. Create a .amazonq/rules folder in your project root.
  2. Add Markdown files in this folder to define rules (e.g., cdk-rules.md).
  3. Write detailed prompts in these files, such as coding standards or best practices.
  4. Amazon Q Developer will automatically use these rules when generating code or providing assistance.

Example rule:

All Amazon S3 buckets must have encryption enabled, enforce SSL, and block public access.
All Amazon DynamoDB Streams tables must have encryption enabled.
All Amazon SNS topics must have encryption enabled and enforce SSL.
All Amazon SNS queues must enforce SSL.

Feedback

To provide feedback on Amazon Q Developer, create an issue in the Amazon Q Developer public repository.

For more detailed information, visit the Amazon Q for GitHub documentation.

Footnotes

  1. Amazon Q Developer uses generative AI. You may need to verify generated code before using it in your environment. See the AWS Responsible AI Policy.

@poad

poad commented Sep 20, 2025

Copy link
Copy Markdown
Owner Author

/oc レユーして

@opencode-agent

opencode-agent Bot commented Sep 20, 2025

Copy link
Copy Markdown

UnknownError:

opencode session  |  github run

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビュー概要

このPRは「Add the Event Trigger」というタイトルでGitHub ActionsワークフローにPull Requestトリガーを追加していますが、重要な設定上の問題があります。

主な問題点

ロジックエラー: pull_requestトリガーを追加しましたが、ジョブの実行条件(if文)がissue_commentイベントのみを想定しているため、pull_requestイベントでは常にジョブがスキップされます。

推奨される修正

  1. pull_requestトリガーに適切なtypesを指定(例:[opened, synchronize]
  2. ジョブの実行条件にイベントタイプ別の条件分岐を追加
  3. 各イベントタイプで適切に動作することをテスト

この修正により、ワークフローがPull Requestイベントでも正常に動作するようになります。

Comment thread .github/workflows/opencode.yml
Comment thread .github/workflows/opencode.yml
@poad
poad force-pushed the feat/opencode-pull-request branch from 99290de to 9f49f88 Compare September 20, 2025 06:41
@poad
poad force-pushed the feat/opencode-pull-request branch from 9f49f88 to 5df9551 Compare September 20, 2025 06:41
@poad

poad commented Sep 20, 2025

Copy link
Copy Markdown
Owner Author

/oc レビューして

@opencode-agent

opencode-agent Bot commented Sep 20, 2025

Copy link
Copy Markdown

UnknownError:

opencode session  |  github run

@poad

poad commented Sep 20, 2025

Copy link
Copy Markdown
Owner Author

/oc レビューして

@opencode-agent

opencode-agent Bot commented Sep 20, 2025

Copy link
Copy Markdown

UnknownError:

opencode session  |  github run

@poad

poad commented Sep 20, 2025

Copy link
Copy Markdown
Owner Author

/oc レビューして

@opencode-agent

opencode-agent Bot commented Sep 20, 2025

Copy link
Copy Markdown

UnknownError:

opencode session  |  github run

@poad
poad marked this pull request as ready for review September 20, 2025 07:02
@poad
poad merged commit 0cf9522 into main Sep 20, 2025
6 checks passed
@poad
poad deleted the feat/opencode-pull-request branch September 20, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant